Skip to content

Peer-review -- Sami Vuorijärvi

Lab 2 review

As you mentioned in a comment in your code, you have some work left with modifying the code to run in pipelined mode. Let me know when that work is done and your program passes CI, and I'll take a second look.

General

  • Repo structure follows the original.

  • All required files are present.

The code

  • Code builds without errors.

  • Code follows lab instructions regarding fp, sp and ra.

  • Illustration of the stack frame looks correct.

Comments:

Code actually does build without any errors, but it's not adapted for running in pipelined mode as you have mentioned in a comment.

Part 1

  • Lab1b (single-cycle) cycle count presented.

  • Lab2 (pipelined) cycle count presented.

  • Speed-up calculated and presented with at least 3 decimal places.

Part 2

  • Cycle count for timed interrupts presented.

  • Cycle count for timed and input interrupts presented.

  • The increased cycle count due to interrupts explained.

The compiled program

  • The program produces the correct result.

  • The resulting decoded string is placed correctly.

  • The resulting string is zero terminated.

  • The program reaches infinite loop when finished.

  • The code has passed CI.

Edited by Sami Vuorijärvi