Peer review Lukas Granberg
- Make sure the repo structure follows the original lab, and that program compiles and works as intended. If not describe the problem in the issue.
- It seems to follow the original and it passes the pipeline. Running it on Syncrim gets the correct outtext.
- Check the following and make issues accordingly.
Run the program until end and check that the outtext is correctly updated (the input reversed).
- It is correct
Check that the code implements a recursive subroutine "rev" using a frame pointer following the D0013E calling convention (see "MIPS Programming").
- It does use a recursive
Check that the subroutine should takes three arguments: the address of the first character to copy, the destination address for that character, and the number of characters to copy, and that "rev" has no return value(s).
- yes well done!
Check that the use of stack and frame pointers are well commented and easy to follow.
- It seems correct to be correct
Check that a stack frame diagram is provided, and that the code follows the diagram.
- it is well done.
Check that the program provides sufficient high level comments in order to understand the implementation.
- You can follow it clearly.
If no errors are found, suggest possible improvements or highlight good practices in the code.
- In general a you've done a good job. Only thing that I thought about that shouldn't really matter. the Copy: is from lab0b and I believe it shouldn't be used here. Doesn't really matter just saw it so thought I could comment on it. I instead made a label for
rev_initialize
. But as I already mentioned doesn't change anything.
Side note: Sorry for the late peer review but last time I checked it the lab wasn't completed nor was I able to open an issue.