Review Labb 1a Axel
Run the program until end and check that the outtext is correctly updated (the input reversed).
- The program runs and the outtext is correct ("Hello World!")
Check that the code implements a recursive subroutine "rev" using a frame pointer following the D0013E calling convention (see "MIPS Programming").
- The program utilises rev recursively with the frame pointer correctly
Check that the subroutine should takes three arguments: the address of the first character to copy, the destination address for that character, and the number of characters to copy, and that "rev" has no return value(s).
- It takes in arguments for stack pointer, frame pointer and return adress. The rev function returns no value
Check that the use of stack and frame pointers are well commented and easy to follow.
- The code could be more well-commented, displaying how they connect
Check that a stack frame diagram is provided, and that the code follows the diagram.
- The stack frame diagram is clear and follows the code
Check that the program provides sufficient high level comments in order to understand the implementation.
- The program is well commented, but could be more elaborant
If no errors are found, suggest possible improvements or highlight good practices in the code.
- The stack seems to not be cleared, hence the code finishes with exit code 1. Otherwise, overall good code that works efficiently.