Lukas Granberg Peer review
-
Your code passes the pipeline and seems like it is all correct.
-
Wouldn't hurt to add some comments over each label to explain what that part does but is definetley not needed as the names of the labels already makes it pretty clear.
-
Another thing is the way you did your pcb increment checking if it is on 1 2 or 3.I think you could make it more simplistic by only checking if it is on the third pcb to do 1 thing and if it is on 1 or 2 just go to next.
-
so something like ` la $t1, pcb3
la $t2, pcb1
beq $k0, $t1, nextis1
is1or2:
addiu $k0, $zero, 12 # 12 becouse each pcb is 3 words.
b restore
nop
is3:
addiu $k0, $zero, pcb1
`
- It doesn't really change much but pretty much the only thing i could comment on so tough I would bring it up.
- Good Job!
Edited by Lukas Granberg